Wireshark-commits: [Wireshark-commits] master 52910f4: isakmp: fix type confusion
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 23 Aug 2016 04:12:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=52910f4e3fa7d771a671cd30bd5320d70aee3eec
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

52910f4 by Peter Wu (peter@xxxxxxxxxxxxx):

    isakmp: fix type confusion
    
    Caught by ASAN with WIRESHARK_DEBUG_WMEM_OVERRIDE=simple set.
    
    Manually inspection of all type casts to decrypt_data_t and
    ikev2_decrypt_data_t showed no other users that do not check
    isakmp_version first.
    
    Change-Id: If889afff85a20e31222d33cbea8db3a91a77f389
    Reviewed-on: https://code.wireshark.org/review/17246
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michał Skalski <mskalski13@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  bee0cd7   See if *this* convinces the compiler that valuelen and value will be set.
    adds  52910f4   isakmp: fix type confusion


Summary of changes:
 epan/dissectors/packet-isakmp.c |   24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)