Wireshark-commits: [Wireshark-commits] master e83bdc6: wmem_array_index() returns a *pointer* to th
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 22 Aug 2016 07:38:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e83bdc67cc413c25321ae75792a2c92d55b6e544
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e83bdc6 by Guy Harris (guy@xxxxxxxxxxxx):

    wmem_array_index() returns a *pointer* to the array element.
    
    The array is an array of guint8 *'s that point to strings;
    wmem_array_index() doesn't return a pointer to the string, it returns a
    pointer to a pointer to the string, and you have to dereference the
    result of the wmem_array_index() call to get a pointer to the string.
    
    Change-Id: I8c7b3320f0979b01383ad255419c21cdeb7df4c7
    Reviewed-on: https://code.wireshark.org/review/17221
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c00ea6f   Look up the XML dissector the right way.
    adds  e83bdc6   wmem_array_index() returns a *pointer* to the array element.


Summary of changes:
 epan/dissectors/packet-pcp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)