Wireshark-commits: [Wireshark-commits] master c3a8a0c: netlink: fix flags dissection
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 19 Aug 2016 11:23:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c3a8a0ce8ad391bda135fe39f304cc23e3025101
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c3a8a0c by Peter Wu (peter@xxxxxxxxxxxxx):

    netlink: fix flags dissection
    
    Flags are not in network byte order, use given encoding instead.
    
    Show both flags fields for GET and NEW requests since the netlink
    dissector cannot yet determine whether a request is for GET, NEW or
    something else. This has no effect for the sockdiag dissector but it
    will influence the route and netfilter netlink subdissectors.
    
    Change-Id: I472ff9e0498debbbceef657a14408c4e6a9df75b
    Reviewed-on: https://code.wireshark.org/review/17118
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d2ee571   dissector ISAKMP: Added decryption using AES-GCM, AES-CCM and AES-CTR
    adds  c3a8a0c   netlink: fix flags dissection


Summary of changes:
 epan/dissectors/packet-netlink.c |   25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)