Wireshark-commits: [Wireshark-commits] master-2.2 ba26f80: [H248] Fix Warn Dissector bug, protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 16 Aug 2016 11:46:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba26f8046b851d7153afc706144e8900f3700f98
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

ba26f80 by AndersBroman (anders.broman@xxxxxxxxxxxx):

    [H248] Fix Warn Dissector bug, protocol H248, in packet 1: tvbuff.c:532: failed assertion "tvb && tvb->initialized"
    
    gcp_analyze_msg() is called with a NULL tvb, remove h248_tvb and use tvb
    instead.
    
    Change-Id: I2cb4c3577817bbaa4ec50b2a5ef0ef296059e683
    Reviewed-on: https://code.wireshark.org/review/17082
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit dfbfdc411c11a5c49307a3125810f65a099bdd85)
    Reviewed-on: https://code.wireshark.org/review/17084
    

Actions performed:

    from  f4a0a34   extcap: Fix Dereference of null pointer
    adds  ba26f80   [H248] Fix Warn Dissector bug, protocol H248, in packet 1: tvbuff.c:532: failed assertion "tvb && tvb->initialized"


Summary of changes:
 epan/dissectors/asn1/h248/h248.cnf               |    2 +-
 epan/dissectors/asn1/h248/packet-h248-template.c |    2 --
 epan/dissectors/packet-h248.c                    |   10 ++++------
 3 files changed, 5 insertions(+), 9 deletions(-)