Wireshark-commits: [Wireshark-commits] master-2.0 f5c7b56: Don't snprintf() into a string with one
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 3 Aug 2016 03:40:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f5c7b56db8eb6792eddcf87499fea651927dbdd2
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

f5c7b56 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't snprintf() into a string with one of the arguments being the same string.
    
    That doesn't work - you could be writing into the string from which
    you're reading.
    
    Bug: 12700
    
    Change-Id: I2fc6416e0613791dcd37ef70dbf00aae159008de
    Reviewed-on: https://code.wireshark.org/review/16852
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  3f9ce2c   Allow test of the -D and -L options to succeed or fail with a permissions error.
    adds  f5c7b56   Don't snprintf() into a string with one of the arguments being the same string.


Summary of changes:
 asn1/h225/h225.cnf            |   46 +++++++-----
 epan/dissectors/packet-h225.c |  158 ++++++++++++++++++++++-------------------
 2 files changed, 116 insertions(+), 88 deletions(-)