Wireshark-commits: [Wireshark-commits] master cec2946: CANopen: Added some improvements to CANopen
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 2 Aug 2016 11:58:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cec29464601400a56cb79b733f45977e3220cdf5
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cec2946 by Adrien Aubry (adraub@xxxxxxxxx):

    CANopen: Added some improvements to CANopen emergency dissector
    
    -Added description to Emergency error code
    -Added bitmask dissector to Emergency register
    -Added descriptions to object dictionary SDO related index
    All these changes were found inside the CiA CANopen norm, and were useful
    in my work while debugging CANopen frames
    
    Change-Id: I76bc1eab9f75fc242eaf3200af81593f65570658
    Reviewed-on: https://code.wireshark.org/review/16823
    Reviewed-by: João Valverde <j@xxxxxx>
    Petri-Dish: João Valverde <j@xxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d62ad9d   extcap: Remove g_spawn_check_exit_status
    adds  cec2946   CANopen: Added some improvements to CANopen emergency dissector


Summary of changes:
 epan/dissectors/packet-canopen.c |  168 ++++++++++++++++++++++++++++++++++++--
 1 file changed, 163 insertions(+), 5 deletions(-)