Wireshark-commits: [Wireshark-commits] master b6d13ef: Register IPv6 extension header dissectors to
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 29 Jul 2016 16:36:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b6d13ef90de224d230300493b38d02b97cf63cde
Submitter: João Valverde (j@xxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b6d13ef by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    Register IPv6 extension header dissectors to "ip.proto" table
    
    We may want to add expert infos for IPv6 extension headers over IPv4 (TODO).
    Any side-effects that don't make sense (e.g: IPv6 Routing over IPv4) are
    ignored.
    
    The IPv6 Next Header decode as is replaced by IP Proto decode as. It
    didn't fit a conceptual model well and it also was not working very well
    in practice (for multiple extension headers).
    
    We now support decoding any IP Protocol number as an extension header.
    
    Bug: 12673
    Change-Id: Icbde019aba8990cc556ef2bd832f64cba76c24b6
    Reviewed-on: https://code.wireshark.org/review/16681
    Petri-Dish: João Valverde <j@xxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: João Valverde <j@xxxxxx>
    

Actions performed:

    from  042b49a   editcap: fix typos
    adds  b6d13ef   Register IPv6 extension header dissectors to "ip.proto" table


Summary of changes:
 epan/dissectors/packet-gre.c    |    1 -
 epan/dissectors/packet-icmp.c   |    1 -
 epan/dissectors/packet-icmpv6.c |    1 -
 epan/dissectors/packet-ipsec.c  |   42 ++++++-
 epan/dissectors/packet-ipv6.c   |  254 +++++++++++++++++++--------------------
 epan/dissectors/packet-ipv6.h   |    3 +
 epan/dissectors/packet-mip6.c   |    1 -
 epan/dissectors/packet-ospf.c   |    1 -
 epan/dissectors/packet-sctp.c   |    1 -
 epan/dissectors/packet-shim6.c  |    4 +-
 epan/dissectors/packet-tcp.c    |    1 -
 epan/dissectors/packet-udp.c    |    2 -
 epan/dissectors/packet-vines.c  |    1 -
 13 files changed, 168 insertions(+), 145 deletions(-)