Wireshark-commits: [Wireshark-commits] master 7b75871: packet-smb2: fix data type of share_type
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 26 Jul 2016 11:32:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7b75871bd9faacb948475eae4afbc7e4bd4a4c9a
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7b75871 by Hiroshi Ioka (hirochachacha@xxxxxxxxx):

    packet-smb2: fix data type of share_type
    
    According to spec,
    
    https://msdn.microsoft.com/en-us/library/cc246499.aspx
    
    share_type uses 1 byte.
    But, current implementation allocates 2 bytes for it.
    
    Change-Id: Ibf55c49168a417c16bde57aad368a1265040afae
    Reviewed-on: https://code.wireshark.org/review/16695
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d860d5a   BGP: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
    adds  7b75871   packet-smb2: fix data type of share_type


Summary of changes:
 epan/dissectors/packet-smb2.c |    4 ++--
 epan/dissectors/packet-smb2.h |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)