Wireshark-commits: [Wireshark-commits] master 913e0f4: Use Windows CRT string functions in some pla
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 21 Jul 2016 20:09:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=913e0f408c48f3baf6933807f9cfe4195fde5c75
Submitter: João Valverde (j@xxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

913e0f4 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Use Windows CRT string functions in some places.
    
    Copy wsutil/wsprintf.h from change 16537. Update it to use functions
    appropriate to Visual C++ >= 2015, < 2015, and everything else. Add
    notes about specific API issues.
    
    Update epan/expert.c to use ws_snprintf, since the VS profiler shows it
    as a minor hot spot. This reduces load time for a large-ish capture from
    ~14s to ~12s here.
    
    Migrate a previous column-utils change.
    
    Change-Id: Id4064b7c06c35fd447b63c73f731afee181df4f9
    Reviewed-on: https://code.wireshark.org/review/16483
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: João Valverde <j@xxxxxx>
    

Actions performed:

    from  97d194c   Qt: Set the LabelStack CSS only when it changes.
    adds  913e0f4   Use Windows CRT string functions in some places.


Summary of changes:
 epan/column-utils.c |   22 +++---------
 epan/expert.c       |    4 ++-
 wsutil/Makefile.am  |    3 +-
 wsutil/ws_printf.h  |  100 +++++++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 109 insertions(+), 20 deletions(-)
 create mode 100644 wsutil/ws_printf.h