Wireshark-commits: [Wireshark-commits] master 29a98d1: Allow BASE_NONE (with strings conversion) fo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 20 Jul 2016 03:01:10 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=29a98d1c7f09cba3a1e20ae6bfce76cf13e134fe
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

29a98d1 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Allow BASE_NONE (with strings conversion) for integral values again.
    
    This mostly reverts SVN rev 43412 (3fa645481f82e32d5ad01ebce9c482c4edae31ae)
    with the addition of documenting that FT_*INT*'s with BASE_NONE and a
    FIELDCONVERT tells the Wireshark core that the field's numeric value is
    meaningless and should not be shown to the user.
    
    Use BASE_NONE again with the expert info group and severity fields.  This
    (finally) resolves the complaint from:
    
    https://www.wireshark.org/lists/wireshark-dev/201206/msg00188.html
    
    (yes, this mail's been sitting in my "todo" pile since then! <sigh>)
    
    Change-Id: I1c6dd2864e7a2e959c97c409f277853af74a8d93
    Reviewed-on: https://code.wireshark.org/review/16518
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  83174a2   Qt: Fix Windows taskbar progress behavior.
    adds  29a98d1   Allow BASE_NONE (with strings conversion) for integral values again.


Summary of changes:
 doc/README.dissector |   13 ++++++++++---
 epan/expert.c        |    4 ++--
 epan/proto.c         |   18 +++++++++++++++---
 3 files changed, 27 insertions(+), 8 deletions(-)