Wireshark-commits: [Wireshark-commits] master d26e151: AH: Remove ah_header_data and subtree payloa
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 19 Jul 2016 18:45:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d26e15113246cd9541d99d915098bf60f7424efb
Submitter: João Valverde (j@xxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d26e151 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    AH: Remove ah_header_data and subtree payload preference
    
    When combined with the IPv6 preference for extension headers under the
    IPv6 header tree it's too many hierarchical levels, confusing in code
    and UX.
    
    Change-Id: Ia593da8ef543d1014b9e7575084a72b5b630ea08
    Reviewed-on: https://code.wireshark.org/review/16539
    Reviewed-by: João Valverde <j@xxxxxx>
    

Actions performed:

    from  d75de9f   VXLAN: use the newly created vxlan.next_proto dissector table everywhere
    adds  d26e151   AH: Remove ah_header_data and subtree payload preference


Summary of changes:
 epan/dissectors/packet-ipsec.c |   49 +++++++---------------------------------
 1 file changed, 8 insertions(+), 41 deletions(-)