Wireshark-commits: [Wireshark-commits] master d54f372: Remove wtap_block_num_options_of_type().
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 18 Jul 2016 19:47:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d54f372c999ce1bf1437a7718301265e2c1f15cb
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d54f372 by Guy Harris (guy@xxxxxxxxxxxx):

    Remove wtap_block_num_options_of_type().
    
    It's not used; currently, everything that accesses instances of a
    multiple-instance-allowed option do so in a loop that iterates over
    option instances by fetching values of the Nth option until the attempt
    to fetch the option fails, making only one pass over the options.
    
    Change-Id: Ife9583a5d246027dbfc133ab58027ef6641d65ef
    Reviewed-on: https://code.wireshark.org/review/16534
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d08e767   IPv6: Export ipv6_pinfo interface for sub-dissectors
    adds  d54f372   Remove wtap_block_num_options_of_type().


Summary of changes:
 wiretap/wtap_opttypes.c |   36 ------------------------------------
 1 file changed, 36 deletions(-)