Wireshark-commits: [Wireshark-commits] master abd0033: androiddump.c - Address VS Code Analysis war
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 16 Jul 2016 19:53:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=abd0033c7ed380750aa59e5979e85dc0884ca564
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

abd0033 by Michael Mann (mmann78@xxxxxxxxxxxx):

    androiddump.c - Address VS Code Analysis warnings.
    
    1. Take large "packet" byte arrays off of stack and onto heap.
    2. Cast away an shift operation that should have been identified as safe anyway.
    
    Change-Id: I159c4a7452744763f667336cf4824d5ac3472343
    Reviewed-on: https://code.wireshark.org/review/16500
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  9a9c72c   Have extcap executables mirror the GTK's WinMain signature.
    adds  abd0033   androiddump.c - Address VS Code Analysis warnings.


Summary of changes:
 extcap/androiddump.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)