Wireshark · Wireshark-commits: [Wireshark-commits] master b5a585c: Use timers instead of packet counts to update our UI.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b5a585c0a024858ac5f9c326f63df382872f87e3
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b5a585c by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Use timers instead of packet counts to update our UI.
    
    In file.c, update our UI based on the time elapsed since we last
    finished updating the UI instead of on the number of packets we've
    processed. Remove the timer code from progress_frame.cpp since it's now
    redundant.
    
    This makes the UI more responsive here for captures with large numbers
    of packets and it should mean that packets_bar_update spends less time
    repainting, at least on Windows.
    
    Change-Id: I9edfa944c44192350bef75b8c0c3ad63bae9c131
    Reviewed-on: https://code.wireshark.org/review/16476
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  adec7c4   Allocate data sources using wmem.
    adds  b5a585c   Use timers instead of packet counts to update our UI.


Summary of changes:
 file.c                   |  238 +++++++++++++++++++++-------------------------
 ui/qt/progress_frame.cpp |    8 --
 ui/qt/progress_frame.h   |    1 -
 3 files changed, 111 insertions(+), 136 deletions(-)