Wireshark-commits: [Wireshark-commits] master fb07249: pcapng.c: Use preprocessor directive to comp
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 14 Jul 2016 02:46:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fb0724981c0b46c997ebbafd085dc85a8285674c
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fb07249 by Michael Mann (mmann78@xxxxxxxxxxxx):

    pcapng.c: Use preprocessor directive to compare G_BYTE_ORDER with G_LITTLE_ENDIAN.
    
    VS Code analysis considers them hardcoded values so the if statement is either
    always true or always false.
    
    Change-Id: Iabb8462b66f728195bf378ae26c79a783feddb03
    Reviewed-on: https://code.wireshark.org/review/16422
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  90e97df   packet-ieee80211-radio.c: Prevent array overflow.
    adds  fb07249   pcapng.c: Use preprocessor directive to compare G_BYTE_ORDER with G_LITTLE_ENDIAN.


Summary of changes:
 wiretap/pcapng.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)