Wireshark-commits: [Wireshark-commits] master dec3e2e: randpkt_core: Use g_random_* for randpkt_par
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 10 Jul 2016 14:28:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dec3e2e8aa343f5acdc61df67826b0951b13a663
Submitter: Jo?o Valverde (j@xxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

dec3e2e by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    randpkt_core: Use g_random_* for randpkt_parse_type().
    
    randpkt_parse_type() can (and most likely will) be called before
    randpkt_example_init(), therefore g_rand_int_range is called with a NULL
    GRand argument. This produces non-random output.
    
    Change-Id: Id420edc15a5f9dec427c5f1a1dd9a1f18a225319
    Reviewed-on: https://code.wireshark.org/review/16367
    Reviewed-by: João Valverde <j@xxxxxx>
    

Actions performed:

    from  3ea8ccf   iso14443: the uid size is a generated item
    adds  dec3e2e   randpkt_core: Use g_random_* for randpkt_parse_type().


Summary of changes:
 randpkt_core/randpkt_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)