Wireshark-commits: [Wireshark-commits] master 01c6483: Check for pcapng files when reading from a p
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 9 Jul 2016 07:08:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=01c6483b45a91f8c03eeb4bf80a15a5e174ffb18
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

01c6483 by Guy Harris (guy@xxxxxxxxxxxx):

    Check for pcapng files when reading from a pipe.
    
    That way, people don't get confused by an "Unrecognized libpcap format"
    error - it's *not* libpcap format!
    
    Also, improve *that* message to say "...or not libpcap data", and put a
    period at the end of the error messages.
    
    Change-Id: I175f9399fe99ce424f1d83596b7330e1fa5c0625
    Reviewed-on: https://code.wireshark.org/review/16349
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  94c0f91   Fix value_string_ext_free() constness
    adds  01c6483   Check for pcapng files when reading from a pipe.


Summary of changes:
 dumpcap.c |   51 +++++++++++++++++++++++++++++----------------------
 1 file changed, 29 insertions(+), 22 deletions(-)