Wireshark-commits: [Wireshark-commits] master de90565: packet-tcap.c: Remove MEM_TCAPSRT
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 4 Jul 2016 20:44:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=de905654520d47288fbc891cb09c73346bd8b1cf
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

de90565 by Michael Mann (mmann78@xxxxxxxxxxxx):

    packet-tcap.c: Remove MEM_TCAPSRT
    
    No need to duplicate memory allocation of hash tables to have a "debug copy".
    Maybe a separate wmem allocator can be used within the dissector, but that
    type of debugging shouldn't be in trunk source. Keep it on private branch
    until it's working.
    
    Change-Id: I4bdd0f3d1b613f7ae79aa57ebb8e5c3293023253
    Reviewed-on: https://code.wireshark.org/review/16282
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  276db50   Add length checks.
    adds  de90565   packet-tcap.c: Remove MEM_TCAPSRT


Summary of changes:
 epan/dissectors/asn1/tcap/packet-tcap-template.c |   91 --------------------
 epan/dissectors/packet-tcap.c                    |   97 +---------------------
 2 files changed, 3 insertions(+), 185 deletions(-)