Wireshark-commits: [Wireshark-commits] master 2257478: Fix -T fields, broken by ceae9e4d1fff4500b28
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 29 Jun 2016 23:15:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2257478e92357785cb43c3ff4329c31ea0f4fa25
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2257478 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix -T fields, broken by ceae9e4d1fff4500b285dba021c3f239ff87779e.
    
    Rename write_fields_proto_tree() to write_specified_fields(), and make
    it static.  Make write_fields_proto_tree() a wrapper around
    write_specified_fields() that sets the format to FORMAT_CSV.  Have
    write_specified_fields() fail with an assertion if fields->format isn't
    one of the known formats, to catch problems such as this in the future.
    
    Don't fill in the "data" structure if we're not going to use it.
    
    Change-Id: I11dbf448d72ca389f0e5fb8558a41b7eecf7c9a4
    Reviewed-on: https://code.wireshark.org/review/16210
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  af52c85   packet-nfs: fixup whitespace in pNFS SCSI work
    adds  2257478   Fix -T fields, broken by ceae9e4d1fff4500b285dba021c3f239ff87779e.


Summary of changes:
 epan/print.c |   76 +++++++++++++++++++++++++++++++++++++---------------------
 1 file changed, 49 insertions(+), 27 deletions(-)