Wireshark-commits: [Wireshark-commits] master d90e6e7: There's no need to check the return from g_a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 27 Jun 2016 15:24:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d90e6e74da5e4766b95545120f259a5565071702
Submitter: Jaap Keuter (jaap.keuter@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d90e6e7 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    There's no need to check the return from g_array_index().
    
    g_array_index() returns an index into an array: we're sure to find
    something at that index (whether that something is in bounds is
    a-whole-nother question).
    
    This fixes CIDs 1362829 and 1362890/1362830.  There were other CIDs like
    this but they've already been fixed.
    
    Change-Id: I94af0931b9adf3abd3bedc969e399cda98bbdd07
    Reviewed-on: https://code.wireshark.org/review/16168
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    

Actions performed:

    from  2ab4155   tvb_get_string_enc + proto_tree_add_item = proto_tree_add_item_ret_string
    adds  d90e6e7   There's no need to check the return from g_array_index().


Summary of changes:
 ui/qt/endpoint_dialog.cpp |    8 --------
 1 file changed, 8 deletions(-)