Wireshark-commits: [Wireshark-commits] master e7b78eb: Move AT_USB to inside USB dissector.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 22 Jun 2016 04:58:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e7b78eb0a60a52e844a64452817649126213f771
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e7b78eb by Michael Mann (mmann78@xxxxxxxxxxxx):

    Move AT_USB to inside USB dissector.
    
    This required some hacking in the conversation table handling, but
    still seemed worth it as USB address is not widely used.
    Maybe a "is_stringlike" property for address types...
    
    Change-Id: I628a15c17cb1f595bb292130867adbc5bea0f41a
    Reviewed-on: https://code.wireshark.org/review/16068
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3ed06ec   The C standard requires <stdlib.h> for getenv() and abort().
    adds  e7b78eb   Move AT_USB to inside USB dissector.


Summary of changes:
 epan/address.h               |    2 --
 epan/address_types.c         |   39 ------------------------------------
 epan/conversation_table.c    |   17 +++++++++++++---
 epan/dissectors/packet-usb.c |   45 +++++++++++++++++++++++++++++++++---------
 4 files changed, 50 insertions(+), 53 deletions(-)