Wireshark-commits: [Wireshark-commits] master 561a063: Pass "/utf-8" to Visual C++ 2015.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 15 Jun 2016 20:51:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=561a063feee5b3ea8ac9d7d3254e16ec31bb7646
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

561a063 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Pass "/utf-8" to Visual C++ 2015.
    
    Many projects (Qt[1] and GNOME[2] in particular) either recommend, use,
    or at least allow for UTF-8 in source and header files. Pass /utf-8 to
    Visual C++ 2015 so that it will behave itself around UTF-8 and be more
    like that nice compiler down the street.
    
    [1] https://wiki.qt.io/Strings_and_encodings_in_Qt
    [2] https://bugzilla.gnome.org/show_bug.cgi?id=767218
    
    Change-Id: Ibc90d235742134cb42dd796ba529699bcbbe3ad0
    Reviewed-on: https://code.wireshark.org/review/15821
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ca1c5f5   diameter (3GPP): Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
    adds  561a063   Pass "/utf-8" to Visual C++ 2015.


Summary of changes:
 CMakeLists.txt |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)