Wireshark-commits: [Wireshark-commits] master ec5acbc: wtap: Make default_filter static
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 15 Jun 2016 17:56:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ec5acbc33cfc8e6c82706574814d7232b26112c0
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ec5acbc by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    wtap: Make default_filter static
    
    Address of stack memory associated with local variable 'default_filter'
    is still referred to by the global variable 'filter_option' upon returning
    to the caller.  This will be a dangling reference.
    
    Change-Id: I6160a37f05b8aea245b723ec50803e4062886738
    Reviewed-on: https://code.wireshark.org/review/14427
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9ba9a05   Display "IP DSCP" column as short text
    adds  ec5acbc   wtap: Make default_filter static


Summary of changes:
 wiretap/wtap_opttypes.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)