Wireshark-commits: [Wireshark-commits] master cee3e82: CMake: Make PROJECT_VERSION_EXTENSION code s
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 Jun 2016 19:30:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cee3e827ebcc1d4524c19208b9a1196cb0e4f7a2
Submitter: Jo?o Valverde (j@xxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cee3e82 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    CMake: Make PROJECT_VERSION_EXTENSION code simpler
    
    The intent was to allow all sorts of overrides but, ugly.
    
    I don't think we need $cmake_package_string either, at least with
    these changes.
    
    Follow-up to 7c6e859ccf210a45e1cc0f6da17692845e6b5a23.
    
    (And bdec712166ba924a2cdeaaca8ae580c343eaf02c).
    
    Change-Id: I808b6bd3a3c64d2a67165344e8fe23e8314c27db
    Reviewed-on: https://code.wireshark.org/review/15835
    Reviewed-by: João Valverde <j@xxxxxx>
    

Actions performed:

    from  38d39f2   Have MemoryCheck() directly incorporate the error message and exit.
    adds  cee3e82   CMake: Make PROJECT_VERSION_EXTENSION code simpler


Summary of changes:
 CMakeLists.txt  |   12 ++++--------
 make-version.pl |    7 ++-----
 2 files changed, 6 insertions(+), 13 deletions(-)