Wireshark-commits: [Wireshark-commits] master 23d1fed: Qt: Fix "applicable" capture interface behav
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 7 Jun 2016 15:39:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=23d1fed59f20e813088252bac268df142fa96e80
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

23d1fed by Gerald Combs (gerald@xxxxxxxx):

    Qt: Fix "applicable" capture interface behavior.
    
    In the Capture Interfaces dialog, make sure we have exactly one of a
    "not applicable" dash or a checkbox. Otherwise if your interface falsely
    reports that it supports monitor mode you might end up with both.
    
    Change-Id: I9b256f1ef0e8ff32626e7f2b526130f3c110d142
    Reviewed-on: https://code.wireshark.org/review/15761
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  767a59e   Don't sign extend unsigned integer fields larger than 32 bits.
    adds  23d1fed   Qt: Fix "applicable" capture interface behavior.


Summary of changes:
 ui/qt/capture_interfaces_dialog.cpp |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)