Wireshark-commits: [Wireshark-commits] master 767a59e: Don't sign extend unsigned integer fields la
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 7 Jun 2016 09:56:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=767a59e54e6df17f7d8e2c6806ce16062d17e6d7
Submitter: Jaap Keuter (jaap.keuter@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

767a59e by Jens Kilian (jens.kilian@xxxxxxxxxxxxx):

    Don't sign extend unsigned integer fields larger than 32 bits.
    
    Fix a bug in proto_tree_set_uint64() which caused fields to be sign extended.
    (This only showed up when a non-zero bitmask was present.)
    
    Change-Id: Ibcc986e3d42f97348966ea66c2ae9fca73b09992
    Reviewed-on: https://code.wireshark.org/review/15764
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    

Actions performed:

    from  f7cd537   PIMv2 Hello packet incorrectly dissect Option 1
    adds  767a59e   Don't sign extend unsigned integer fields larger than 32 bits.


Summary of changes:
 epan/proto.c |    4 ----
 1 file changed, 4 deletions(-)