Wireshark-commits: [Wireshark-commits] master 0ec5a27: Qt: RTP audio stream fixups.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 6 Jun 2016 23:37:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0ec5a271ea96e92d80060bded7245749a71e199d
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0ec5a27 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: RTP audio stream fixups.
    
    Make sure audio_stream_ is non-NULL before we try to use it. Delete
    audio_stream_ more gracefully and add a note about mutexes on OS X and
    Windows.
    
    Bug: 12166
    Change-Id: I12e76c49e631bc1de813c5c7d82c7d928c71237e
    Reviewed-on: https://code.wireshark.org/review/15759
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  f1ff320   Move ip6_to_str_buf() to to_str.c and make it take the buffer length.
    adds  0ec5a27   Qt: RTP audio stream fixups.


Summary of changes:
 ui/qt/rtp_audio_stream.cpp  |   16 +++++++++++-----
 ui/qt/rtp_audio_stream.h    |    2 +-
 ui/qt/rtp_player_dialog.cpp |    3 ++-
 3 files changed, 14 insertions(+), 7 deletions(-)