Wireshark-commits: [Wireshark-commits] master ed42a48: mgcp: clean up dissect_mgcp()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 31 May 2016 10:32:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ed42a485ef6c64b568969b7697cb1f25d6ecd43d
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ed42a48 by Martin Kaiser (wireshark@xxxxxxxxx):

    mgcp: clean up dissect_mgcp()
    
    remove some if (tree) checks
    rewrite the initial check for a valid packet
    use the correct data type for ti
    
    Change-Id: I56f103be074606e7741db395976e28b4fe27d137
    Reviewed-on: https://code.wireshark.org/review/15629
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  aba533c   mgcp: don't throw an exception while checking if it is our packet
    adds  ed42a48   mgcp: clean up dissect_mgcp()


Summary of changes:
 epan/dissectors/packet-mgcp.c |  119 +++++++++++++++++++----------------------
 1 file changed, 56 insertions(+), 63 deletions(-)