Wireshark-commits: [Wireshark-commits] master 6952c13: Qt: Add Time and Comment labels to the seque
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 25 May 2016 06:36:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6952c1342a7c4ff1828e0bc1a36cfcfd394ee923
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6952c13 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Add Time and Comment labels to the sequence diagram.
    
    Add "Time" and "Comment" labels to the sequence diagram similar to the
    GTK+ UI. Draw a border around the diagram as well.
    
    Widen the default spacing and set it to a simple em-width multiple.
    
    Fix our port number alignment.
    
    Copy over the sequence diagram colors from the GTK+ UI and add them to
    ColorUtils. Color sequences according to their respective conversation
    numbers.
    
    To do:
    - Add zoom.
    
    Ping-Bug: 12419
    Change-Id: I3f9b4ffbfcc34aae1c38e303cd36ff207be247b1
    Reviewed-on: https://code.wireshark.org/review/15554
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  bf62898   Remove an extra break from a copy-and-pasteo.
    adds  6952c13   Qt: Add Time and Comment labels to the sequence diagram.


Summary of changes:
 ui/qt/color_utils.cpp      |   70 ++++++++++++++++++++++++++++----------
 ui/qt/color_utils.h        |    8 +++--
 ui/qt/sequence_diagram.cpp |   69 +++++++++++++++++++++----------------
 ui/qt/sequence_dialog.cpp  |   81 +++++++++++++++++++++++++++++++-------------
 ui/qt/sequence_dialog.h    |    4 ++-
 5 files changed, 157 insertions(+), 75 deletions(-)