Wireshark-commits: [Wireshark-commits] master 61ca435: TCPCL: Return -1 when tcp_dissect_pdus asks
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 23 May 2016 08:06:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=61ca43521bdf43ad61db187e8c79c3528f693ddc
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

61ca435 by Michael Mann (mmann78@xxxxxxxxxxxx):

    TCPCL: Return -1 when tcp_dissect_pdus asks for a length and it doesn't look like a TCPCL packet.
    
    This will stop dissection of Bundle packets, but more importantly
    prevents assertion in TCP dissector when trying to reassemble
    the packets as TCPCL/Bundle.
    
    Bug: 11395
    Bug: 12462
    Change-Id: I3a2ccd5e02022dfe03bc93d81bfbd3f2d3bcd8aa
    Reviewed-on: https://code.wireshark.org/review/15537
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9b0b20b   Make sure EAPOL body is big enough for a EAPOL_RSN_KEY.
    adds  61ca435   TCPCL: Return -1 when tcp_dissect_pdus asks for a length and it doesn't look like a TCPCL packet.


Summary of changes:
 epan/dissectors/packet-dtn.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)