Wireshark · Wireshark-commits: [Wireshark-commits] master dd16f65: manolito (CID 1355642): avoid shifting by 32 bits

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dd16f650fd231df31fe675e862adee69592fb7f2
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

dd16f65 by Martin Kaiser (wireshark@xxxxxxxxx):

    manolito (CID 1355642): avoid shifting by 32 bits
    
    The result of shifting a 32bit value by 32 bits is undefined.
    
    Avoid all of the shift operations. Use the appropriate functions to get
    the value from the tvb.
    
    It seems that a manolito integer can be up to 5 octets. Use data types
    large enough to store the possible values.
    
    Change-Id: Icc1b538dbd7cdb27700140e9e5b81458b1047537
    Reviewed-on: https://code.wireshark.org/review/15481
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  1498220   [skinny] Update message definitions
    adds  dd16f65   manolito (CID 1355642): avoid shifting by 32 bits


Summary of changes:
 epan/dissectors/packet-manolito.c |   28 +++++++++++++++++++---------
 1 file changed, 19 insertions(+), 9 deletions(-)