Wireshark-commits: [Wireshark-commits] master a7ba38a: s7comm: fix warning found by clang analyzer
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 14 May 2016 08:02:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a7ba38a72e31287944d86338dcc5d29076c387ad
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a7ba38a by Thomas Wiens (th.wiens@xxxxxx):

    s7comm: fix warning found by clang analyzer
    
    Fixed warnings about Dead store / Dead assignment found by clang
    analyzer.
    Fixed encoding to be compatible to hf-type.
    
    Change-Id: Iba93abe21f87029d53cd1db111b372cd4bd76229
    Reviewed-on: https://code.wireshark.org/review/15418
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  bda417a   Use g_get_charset instead of g_get_codeset.
    adds  a7ba38a   s7comm: fix warning found by clang analyzer


Summary of changes:
 epan/dissectors/packet-s7comm.c |   75 +++++++++++++++++++--------------------
 1 file changed, 37 insertions(+), 38 deletions(-)