Wireshark-commits: [Wireshark-commits] master-2.0 72f1bfe: Handle frames where the type field is a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 11 May 2016 22:57:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=72f1bfe2dc535ab2a3ff7637e94d74fefdca3bd2
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

72f1bfe by Guy Harris (guy@xxxxxxxxxxxx):

    Handle frames where the type field is a length field.
    
    The BNEP Version 1.0 spec says, for BNEP_GENERAL_ETHERNET packets,
    "Note: Networking Protocol Types as used in this specification SHALL be
    taken to include values in the range 0x0000-0x05dc, used to represent
    the IEEE802.3 length interpretation of the IEEE802.3 length/type
    field.", although it says that it's not mandatory to process those
    packets.
    
    We'll process them.
    
    We don't need an Ethernet dissector handle, so don't fetch one.
    
    Change-Id: I10b1fce62688fc0643435d0a01bdb969577df97e
    Reviewed-on: https://code.wireshark.org/review/13376
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit a5cc29b245e2509d5451caa653e0cf83bee56782)
    Reviewed-on: https://code.wireshark.org/review/15387
    

Actions performed:

    from  46945f4   Fix comment.
    adds  72f1bfe   Handle frames where the type field is a length field.


Summary of changes:
 epan/dissectors/packet-btbnep.c |  147 +++++++++++++++++++++++++++++++++------
 1 file changed, 127 insertions(+), 20 deletions(-)