Wireshark-commits: [Wireshark-commits] master 37ee33c: Dynamically allocate the string for represen
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 May 2016 20:40:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=37ee33c9b2e184089c55d96d65be5996f3b338b6
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

37ee33c by Michael Mann (mmann78@xxxxxxxxxxxx):

    Dynamically allocate the string for representing FT_IEEE_11073_[S]FLOAT.
    
    Most uses of fvalue_to_string_repr() don't provide a buffer to write to, so memory is allocated dynamically inside the function.  Trying to move to where ALL cases don't provide a buffer to simplify fvalue_to_string_repr handling and the underlying functionality of the ftypes.
    
    Change-Id: Iac03e4eb63b5e38311a6472fbe488009ed55206c
    Reviewed-on: https://code.wireshark.org/review/15331
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  fb7cd19   Qt: Keep the OverlayScrollBar from disappearing.
    adds  37ee33c   Dynamically allocate the string for representing FT_IEEE_11073_[S]FLOAT.


Summary of changes:
 epan/proto.c |   53 ++++++++++++++++++++++-------------------------------
 1 file changed, 22 insertions(+), 31 deletions(-)