Wireshark-commits: [Wireshark-commits] master a6a8745: wiretap: fix writing of 1 bytes long options
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 4 May 2016 21:04:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a6a8745bea720727f0aae0acb269dfe3d674305f
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a6a8745 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    wiretap: fix writing of 1 bytes long options in pcapng files
    
    the option length should be 1 byte, not 4 bytes.
    
    Change-Id: I1b356c7ce101f9bbdc9793fc280b6564e12f303f
    Reviewed-on: https://code.wireshark.org/review/15265
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  5b1d42c   snmp: return -1 (not 0) if we need more data from TCP
    adds  a6a8745   wiretap: fix writing of 1 bytes long options in pcapng files


Summary of changes:
 wiretap/wtap_opttypes.c |   11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)