Wireshark-commits: [Wireshark-commits] master b274bdd: Qt: Make the overlay scroll bar work with Qt
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 2 May 2016 15:20:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b274bddbc0e46533f222a71c4075c8681bbd41c3
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b274bdd by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Make the overlay scroll bar work with Qt 4.
    
    In Qt 4, QScrollBar::setRange isn't a slot. Add a setChildRange
    slot and connect to it instead. Add a QT_VERSION_CHECK breadcrumb in
    a comment.
    
    Change-Id: Ie28bbb6bd8249c31154a2fe236667adf1d53df61
    Reviewed-on: https://code.wireshark.org/review/15215
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  2e23b50   Add checkAPI calls to CMake.
    adds  b274bdd   Qt: Make the overlay scroll bar work with Qt 4.


Summary of changes:
 ui/qt/overlay_scroll_bar.cpp |    2 +-
 ui/qt/overlay_scroll_bar.h   |    5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)