Wireshark-commits: [Wireshark-commits] master c34cf30: Note some cases where we don't need to check
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 30 Apr 2016 02:05:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c34cf306ab90307c23371d638478bce1d348388d
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c34cf30 by Guy Harris (guy@xxxxxxxxxxxx):

    Note some cases where we don't need to check the packet length.
    
    These file formats have 16-bit packet lengths, so, even with some extra
    metadata added, the packet data length will never be bigger than
    WTAP_MAX_PACKET_SIZE.  (No, we won't ever reduce WTAP_MAX_PACKET_SIZE.)
    
    Change-Id: I9e1b1d90971f91cc6e5d66d0aa93841445b2bc22
    Reviewed-on: https://code.wireshark.org/review/15186
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  44f72a9   Check for packets bigger than WTAP_MAX_PACKET_SIZE.
    adds  c34cf30   Note some cases where we don't need to check the packet length.


Summary of changes:
 wiretap/camins.c              |    6 ++++++
 wiretap/commview.c            |    5 +++++
 wiretap/csids.c               |    5 +++++
 wiretap/ipfix.c               |    5 +++++
 wiretap/lanalyzer.c           |    5 +++++
 wiretap/logcat.c              |    6 ++++++
 wiretap/netscaler.c           |   13 +++++++++++++
 wiretap/network_instruments.c |    5 +++++
 wiretap/ngsniffer.c           |    5 +++++
 wiretap/peekclassic.c         |   10 ++++++++++
 wiretap/radcom.c              |    5 +++++
 11 files changed, 70 insertions(+)