Wireshark-commits: [Wireshark-commits] master 232b2de: Use "system" for "use system language", and
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 28 Apr 2016 19:34:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=232b2de7bb008a2bc7c3e5eece04aab16215d24c
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

232b2de by Guy Harris (guy@xxxxxxxxxxxx):

    Use "system" for "use system language", and don't try to print a null string.
    
    Add a #define USE_SYSTEM_LANGUAGE for the language string meaning "use
    the system setting", and use that instead of hardcoding "system" in
    various places.
    
    If "language" is null, don't try to write it to the file with fprintf()
    - on *most* systems, that prints "(null)", but on some systems, such as
    Solaris, it *crashes*.  Write USE_SYSTEM_LANGUAGE instead.  Check for
    "(null)" and treat it as meaning "use the system language".
    
    Map "auto" to "use the system language" as well, for backwards
    compatibility.
    
    Change-Id: Iba9be540a5139e9cca8bddd0761ee4cbf0f79a49
    Reviewed-on: https://code.wireshark.org/review/15147
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  7150588   Qt: Refresh the display filter toolbar layout.
    adds  232b2de   Use "system" for "use system language", and don't try to print a null string.


Summary of changes:
 ui/language.c                           |   17 ++++++++++++++---
 ui/language.h                           |    2 ++
 ui/qt/main_window_preferences_frame.cpp |    2 +-
 ui/qt/wireshark_application.cpp         |    3 ++-
 4 files changed, 19 insertions(+), 5 deletions(-)