Wireshark · Wireshark-commits: [Wireshark-commits] master dc3aa26: Qt UAT: call the UAT update callback after each field is updated

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dc3aa26dd3acbe76d4dd91910d03927776db8eb1
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

dc3aa26 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Qt UAT: call the UAT update callback after each field is updated.
    
    This fixes a crash when changing the SCCP dissector's users table when
    finishing the edit of a string column by clicking elsewhere (rather than
    pressing Enter/Return) or when changing an enum column.
    
    (The SCCP dissector depends on that update callback being called before the
    copy callback.)
    
    To do this:
     1) Use the editingFinished signal rather than looking for Enter/Return key
        presses (so that a focus change is processed as the end of an edit).
     2) Call the update callback when an enum field changes.
    
    Bug: 12364
    Change-Id: I1884c67b6e873b46afe33703581d0b3dccbbdaf1
    Reviewed-on: https://code.wireshark.org/review/15059
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e19babf   Bounds check the use of ett_zbee_zcl_pwr_prof_enphases array.
    adds  dc3aa26   Qt UAT: call the UAT update callback after each field is updated.


Summary of changes:
 ui/qt/uat_dialog.cpp |   18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)