Wireshark-commits: [Wireshark-commits] master-2.0 fcff256: Restrict the depth of the protocol tree.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 13 Apr 2016 18:47:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fcff25647d06365c916d8d83c14253866ccb32d3
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

fcff256 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Restrict the depth of the protocol tree.
    
    Limit the the protocol tree to 500 levels. This keeps us from running
    out of stack space in proto_tree_traverse_{pre,post}_order.
    
    Bug: 12268
    Change-Id: I60f6b4487bf51a4d43da0429819a8a20fbdb313a
    Reviewed-on: https://code.wireshark.org/review/14887
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 8dc9551e1d56290e6f7f02cc38b77e1d211fd4a5)
    Reviewed-on: https://code.wireshark.org/review/14905
    

Actions performed:

    from  5d321b0   HTTP: treat request_uri as Unicode.
    adds  fcff256   Restrict the depth of the protocol tree.


Summary of changes:
 epan/proto.c |   25 +++++++++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)