Wireshark-commits: [Wireshark-commits] master 5f4f7bc: androiddump: Change insecure sprint into g_s
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 6 Apr 2016 09:00:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5f4f7bcdc1ac412b35c554ff9f6ce76de5a56a6e
Submitter: Michal Labedzki (michal.labedzki@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5f4f7bc by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    androiddump: Change insecure sprint into g_snprintf
    
    This avoid potential overflows.
    
    Bug: 12093
    Change-Id: Icbfe4a9f04c5f8d4e0284e4800d4775773246abf
    Reviewed-on: https://code.wireshark.org/review/14762
    Petri-Dish: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    

Actions performed:

    from  368e3b8   Set the extra type the right way.
    adds  5f4f7bc   androiddump: Change insecure sprint into g_snprintf


Summary of changes:
 extcap/androiddump.c |  160 +++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 140 insertions(+), 20 deletions(-)