Wireshark-commits: [Wireshark-commits] master 2fd8e4b: DNS: change ttl from uint32 to int32.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 4 Apr 2016 12:12:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2fd8e4bdaa33f38af9b539ff0f704acfa8b1fd69
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2fd8e4b by Dario Lombardo (lomato@xxxxxxxxx):

    DNS: change ttl from uint32 to int32.
    
    As stated in the RFC1035 the TTL is a signed int.
    
    https://tools.ietf.org/html/rfc1035#section-3.2.1
    
    Change-Id: I07e57309f83f1877b1b4cb6a085bc3dabf053379
    Reviewed-on: https://code.wireshark.org/review/14759
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  6f98a0f   Rename "libz" to "zlib"
    adds  2fd8e4b   DNS: change ttl from uint32 to int32.


Summary of changes:
 epan/dissectors/packet-dns.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)