Wireshark-commits: [Wireshark-commits] master 24768a7: Assorted cleanups.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 29 Mar 2016 01:38:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=24768a7147b27daba28e2e88c333f0826724fe80
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

24768a7 by Guy Harris (guy@xxxxxxxxxxxx):

    Assorted cleanups.
    
    1) Handle the ASCII and Unicode magic numbers the same way - as static
    const char arrays.  Note that Unicode specifically means little-endian
    UCS-2 (or UTF-16, but they probably use few if any characters outside of
    ASCII, much less the Basic Multilingual Plane).
    
    2) Treat all seek errors as open errors rather than "not my file type".
    
    3) Fix capitalization of "Unicode".
    
    Change-Id: I47b7e057ccada00347499a6b17f8f8fc44e7c503
    Reviewed-on: https://code.wireshark.org/review/14689
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  9f40a75   Trun on -Wused-but-marked-unused but only as warning, never as error. (possibly clang only)
    adds  24768a7   Assorted cleanups.


Summary of changes:
 wiretap/iseries.c |   46 +++++++++++++++++++++++++++++-----------------
 1 file changed, 29 insertions(+), 17 deletions(-)