Wireshark-commits: [Wireshark-commits] master 222d30b: Mikrotik has a protocol that they name Ether
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 Mar 2016 19:45:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=222d30b340b18481c730cdae72b529f720fb221f
Submitter: Jörg Mayer (jmayer@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

222d30b by Joerg Mayer (jmayer@xxxxxxxxx):

    Mikrotik has a protocol that they name Ethernet over IP (EoIP) which has
    nothing to do with IP protocol 97 called EoIP. Instead it is a GRE encapsulation
    with Ethertype 0x6400. It sets the GRE version to 1 but doesn't use a sequence
    number (in violation of RFC2637). Welcome to the real world.
    
    Change-Id: I3d916f8fc134ef14bcaf0b946a10f7170a9f6a75
    Reviewed-on: https://code.wireshark.org/review/14596
    Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx>
    

Actions performed:

    from  e947d36   Override shortcuts in SyntaxLineEdit.
    adds  222d30b   Mikrotik has a protocol that they name Ethernet over IP (EoIP) which has nothing to do with IP protocol 97 called EoIP. Instead it is a GRE encapsulation with Ethertype 0x6400. It sets the GRE version to 1 but doesn't use a sequence number (in violation of RFC2637). Welcome to the real world.


Summary of changes:
 epan/dissectors/packet-eth.c |    2 ++
 epan/dissectors/packet-gre.c |    1 +
 epan/dissectors/packet-gre.h |   62 +++++++++++++++++++++---------------------
 3 files changed, 34 insertions(+), 31 deletions(-)