Wireshark-commits: [Wireshark-commits] master-2.0 9bc329b: gsm_abis_oml: fix buffer overrun
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 20 Feb 2016 14:39:28 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9bc329bec113ddae4e5dcd042ec84cace5b2c16c
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

9bc329b by Peter Wu (peter@xxxxxxxxxxxxx):

    gsm_abis_oml: fix buffer overrun
    
    Do not read outside boundaries when tag is exactly 0xff.
    
        tag = tvb_get_guint8(tvb, offset);
        tdef = find_tlv_tag(tag);
            ...
            return &nm_att_tlvdef_base.def[tag];
    
    Bug: 11825
    Change-Id: I42e624185abb2166aa0f8d0dbd71a2a86fc0b18e
    Reviewed-on: https://code.wireshark.org/review/14030
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit c31425f9ae15067e26ccc6183c206c34713cb256)
    Reviewed-on: https://code.wireshark.org/review/14031
    

Actions performed:

    from  e2242e0   Qt: only "Comment" column should be editable in Local Interfaces management tab
    adds  9bc329b   gsm_abis_oml: fix buffer overrun


Summary of changes:
 epan/dissectors/packet-gsm_abis_oml.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)