Wireshark-commits: [Wireshark-commits] master 472687b: Qt: Fix Open protocol preferences button.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 19 Feb 2016 18:32:37 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=472687b5e1554fd0b7051eb2ee17ca03b9e6211c
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

472687b by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Fix Open protocol preferences button.
    
    Do showProtocolPreferences before removing the variable which
    this depends on.  The button does not work without at module.
    
    Change-Id: I7d31aa5ab19340a4102523b13de961e799cae5e4
    Reviewed-on: https://code.wireshark.org/review/14015
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  de65fd6   rsl: avoid buffer overread
    adds  472687b   Qt: Fix Open protocol preferences button.


Summary of changes:
 ui/qt/preference_editor_frame.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)