Wireshark-commits: [Wireshark-commits] master 4c1869f: Don't call the hci_usb dissector through a d
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 19 Feb 2016 05:02:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4c1869f4871211b3c7518e4858b8372c27013acc
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4c1869f by Guy Harris (guy@xxxxxxxxxxxx):

    Don't call the hci_usb dissector through a dissector table.
    
    It works the same regardless of what flavor of USB metadata there is,
    and there's no good reason for any Bluetooth code to know, or care,
    about particular flavors of USB metadata.
    
    Add some comments while we're at it.
    
    Change-Id: I6ea2063a015e424fc84a407231e80ef3e2a79c98
    Reviewed-on: https://code.wireshark.org/review/14001
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f4580ac   ssl: fix decryption when session ticket is not used
    adds  4c1869f   Don't call the hci_usb dissector through a dissector table.


Summary of changes:
 epan/dissectors/packet-bluetooth.c |   25 ++++++++++++++++++++-----
 epan/dissectors/packet-hci_usb.c   |    5 -----
 2 files changed, 20 insertions(+), 10 deletions(-)