Wireshark-commits: [Wireshark-commits] master 7a1eca1: extcap: Convert settings to preference frien
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 11 Feb 2016 06:41:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7a1eca1726609fcc75594c688756621c3329a509
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7a1eca1 by Mikael Kanstrup (mikael.kanstrup@xxxxxxxxx):

    extcap: Convert settings to preference friendly key names
    
    Preferences are only allowed to contain lowercase ASCII letters,
    numbers, underscores or dot characters. Create a utility function
    to convert an extcap setting to its equivalent preference key and
    use it wherever conversion from setting to preference key is needed.
    
    Bug: 12064
    Change-Id: I39bbac7de5f0f905bd41c54257fa997a3b32442d
    Reviewed-on: https://code.wireshark.org/review/13687
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  fa56b68   GSM RR A: Add variable to avoid some warnings [-Wbad-function-cast]
    adds  7a1eca1   extcap: Convert settings to preference friendly key names


Summary of changes:
 extcap.c                        |   72 +++++++++++++++++++++++++--------------
 extcap.h                        |    3 ++
 ui/qt/extcap_argument.cpp       |    4 +--
 ui/qt/extcap_argument.h         |    2 +-
 ui/qt/extcap_options_dialog.cpp |    7 ++--
 5 files changed, 55 insertions(+), 33 deletions(-)