Wireshark-commits: [Wireshark-commits] master 154e710: pktc: don't THROW() an exception from a diss
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 5 Feb 2016 22:44:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=154e710857599fb91351d955360f1f1dd8eddd22
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

154e710 by Martin Kaiser (wireshark@xxxxxxxxx):

    pktc: don't THROW() an exception from a dissector
    
    in the switch-case statements, we already show an expert info
    it should be sufficient to exit and report to the caller
    how many bytes we dissected
    
    as for the string, we can just calculate the length and let
    proto_tree_add_item() throw an exception if that length is invalid
    
    Change-Id: I310a4011cb112f3ed70e804c5b44d58f275fab6b
    Reviewed-on: https://code.wireshark.org/review/13745
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  b3fb7f4   ENIP: Add dissection of UCMM CPF Item over UDP
    adds  154e710   pktc: don't THROW() an exception from a dissector


Summary of changes:
 epan/dissectors/packet-pktc.c |    6 ------
 1 file changed, 6 deletions(-)