Wireshark-commits: [Wireshark-commits] lts-1.12.1 1d9c54c: Add boundary check for 802.11 decryption
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 5 Feb 2016 20:40:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1d9c54c2dd366d2c9ba1026fe2e877b794aa13dd
Submitter: Balint Reczey (balint@xxxxxxxxxxxxxxx)
Changed: branch: lts-1.12.1
Repository: wireshark

Commits:

1d9c54c by Peter Wu (peter@xxxxxxxxxxxxx):

    Add boundary check for 802.11 decryption
    
    Fixed stack-based buffer overflow when the frame length exceeds 8KB.
    
    Bug: 11790
    Change-Id: I20db8901765a7660e587057e955d4fb5a8645574
    Reviewed-on: https://code.wireshark.org/review/12237
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 40b283181c63cb28bc6f58d80315eccca6650da0)
    [resolved conflict by accepting comments from v2.1.0rc0-764-g9cd66b2]
    Reviewed-on: https://code.wireshark.org/review/12247
    (cherry picked from commit a6e8fc8c9af56124d44423c3a85c695ac01c70e7)
    Reviewed-on: https://code.wireshark.org/review/13761
    Reviewed-by: Balint Reczey <balint@xxxxxxxxxxxxxxx>
    

Actions performed:

    from  ccad93e   SCTP: verify frame pointer before dereferencing it
    adds  1d9c54c   Add boundary check for 802.11 decryption


Summary of changes:
 epan/crypt/airpdcap.c        |    6 ++++++
 epan/crypt/airpdcap_system.h |    6 ++++--
 2 files changed, 10 insertions(+), 2 deletions(-)